Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Review Request 15829: DRILL-312: Modularize org.apache.drill.exec.physical.impl.ImplCreator using operator creator registry


Copy link to this message
-
Re: Review Request 15829: DRILL-312: Modularize org.apache.drill.exec.physical.impl.ImplCreator using operator creator registry
Aditya Kishore 2013-11-27, 10:49

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15829/
-----------------------------------------------------------

(Updated Nov. 27, 2013, 2:49 a.m.)
Review request for drill.
Changes
-------

Updated patch modeled after StorageEngineRegistry.
Bugs: DRILL-312
    https://issues.apache.org/jira/browse/DRILL-312
Repository: drill-git
Description
-------

Added OperatorCreatorRegistry which maintains an physical_operator->operator_creator map used by ImplCreator.
Diffs (updated)
-----

  common/src/main/java/org/apache/drill/common/exceptions/ExecutionSetupException.java 2e50ae5
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java efc0f5b
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/OperatorCreatorRegistry.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java 080fd70
  exec/java-exec/src/test/java/org/apache/drill/exec/client/DumpCatTest.java a78ffc3
  exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestRepeatedFunction.java 3ec9492
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestComparisonFunctions.java 54bf0fd
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java 1776d8d
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestAgg.java b18ef71
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/filter/TestSimpleFilter.java 14d68f3
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoin.java 09b7ebe
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestSimpleLimit.java 89d909d
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/project/TestSimpleProjection.java ca38d9c
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/sort/TestSimpleSort.java 426aa3a
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/svremover/TestSVRemover.java 2da96d7
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/trace/TestTraceMultiRecordBatch.java dd7d006
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/trace/TestTraceOutputDump.java f4e6180
  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/union/TestSimpleUnion.java f74c66f

Diff: https://reviews.apache.org/r/15829/diff/
Testing
-------

Requires DRILL-311 patch.

Passes all unit tests.
Thanks,

Aditya Kishore