Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Pig >> mail # dev >> Re: Review Request: PIG-3331 Default values not written to Schema when specified in the output schema


+
Viraj Bhat 2013-05-30, 02:29
Copy link to this message
-
Re: Review Request: PIG-3331 Default values not written to Schema when specified in the output schema

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11355/#review21304
-----------------------------------------------------------
Hi Viraj,

I have a couple of comments:
- 5k records seems unnecessary for a unit test case. You need just a few records to verify your fix, don't you?
- In you test case, can't you use mock.Storage instead of PigStorage? Then, you won't need an extra input file (numbers.txt). Please see org.apache.pig.builtin.mock.Storage.java.
- Can you put code changes and test files in a single patch and attach it in the jira? It would be very helpful if I could apply everything with a single patch command.

Thank you!

- Cheolsoo Park
On May 30, 2013, 2:29 a.m., Viraj Bhat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11355/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 2:29 a.m.)
>
>
> Review request for pig and Rohini Palaniswamy.
>
>
> Description
> -------
>
> Patch to write default values to the Schema when the writer schema contains that in the AvroStorage.
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigSchema2Avro.java 1485826
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1485826
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/avro_test_files/numbers.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11355/diff/
>
>
> Testing
> -------
>
> Yes against the Piggybank  in Pig trunk/Pig 0.12
>
>
> Thanks,
>
> Viraj Bhat
>
>

+
Viraj Bhat 2013-06-04, 22:18
+
Rohini Palaniswamy 2013-06-03, 13:20
+
Viraj Bhat 2013-06-04, 21:52
+
Viraj Bhat 2013-06-04, 21:50
+
Viraj Bhat 2013-06-04, 23:23
+
Rohini Palaniswamy 2013-06-05, 01:12