Sqoop, mail # dev - Review Request: SQOOP-900 Sqoop2: Introduce human readable coding style for queries stored in DerbySchemaQuery

Review Request: SQOOP-900 Sqoop2: Introduce human readable coding style for queries stored in DerbySchemaQuery

Jarek Cecho 2013-02-17, 04:23

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9485/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've changed the coding style, so that it's easier (at least for me) to see what the queries are doing. I did not change any query - e.g. generated sql should be always the same. Only the appearance in the source code is different.
This addresses bug SQOOP-900.
https://issues.apache.org/jira/browse/SQOOP-900
Diffs
-----

repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 314948cfa07aac1c9bb8ae4656f7a1c0170a57e3

Diff: https://reviews.apache.org/r/9485/diff/
Testing
-------

Unit tests seems to be passing and I've tested this change on real cluster.
Thanks,

Jarek Cecho

Re: Review Request: SQOOP-900 Sqoop2: Introduce human readable coding style for queries stored in DerbySchemaQuery

Cheolsoo Park 2013-02-22, 21:21

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9485/#review16965
-----------------------------------------------------------

Ship it!
Much more readable to me as well. Thanks Jarcec!

- Cheolsoo Park
On Feb. 17, 2013, 4:23 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9485/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2013, 4:23 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've changed the coding style, so that it's easier (at least for me) to see what the queries are doing. I did not change any query - e.g. generated sql should be always the same. Only the appearance in the source code is different.
>
>
> This addresses bug SQOOP-900.
> https://issues.apache.org/jira/browse/SQOOP-900
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 314948cfa07aac1c9bb8ae4656f7a1c0170a57e3
>
> Diff: https://reviews.apache.org/r/9485/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've tested this change on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>