Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hadoop, mail # dev - Report as a bug?


Copy link to this message
-
Report as a bug?
Niels Basjes 2011-01-29, 20:44
I was playing around with PMD, just to see what kind of messages it
gives on my hadoop feature.
I noticed a message about "Dead code" in org.apache.hadoop.fs.ftp.FTPFileSystem

Starting at about line 80:

    String userAndPassword = uri.getUserInfo();
    if (userAndPassword == null) {
      userAndPassword = (conf.get("fs.ftp.user." + host, null) + ":" + conf
          .get("fs.ftp.password." + host, null));
      if (userAndPassword == null) {
        throw new IOException("Invalid user/passsword specified");
      }
    }
The last "if" block is the dead code as the string will always contain
at least the text ":" or "null:null"
It will probably fail a bit later when really trying to login with a
wrong uid/password.
So, is this worth reporting as a bug?

--
Met vriendelijke groeten,

Niels Basjes