Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hive >> mail # dev >> Review Request: Review Request for HIVE-4554 Failed to create a table from existing file if file path has spaces


+
Xuefu Zhang 2013-05-22, 21:24
+
Xuefu Zhang 2013-06-02, 14:03
+
Xuefu Zhang 2013-06-03, 22:18
Copy link to this message
-
Re: Review Request: Review Request for HIVE-4554 Failed to create a table from existing file if file path has spaces

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11335/#review21366
-----------------------------------------------------------
Patch looks good, apart from one comment.
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java
<https://reviews.apache.org/r/11335/#comment44301>

    Apart from this change, all other changes are contained within if(isLocal) block. Because of this it seems its possible it might be triggered for non-local paths as well. Can you test it for hdfs:// path which has spaces. If its easy, it will be good to add it in test, else manual test is fine as well.
- Ashutosh Chauhan
On June 3, 2013, 10:18 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11335/
> -----------------------------------------------------------
>
> (Updated June 3, 2013, 10:18 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Description
> -------
>
> Patch includes fix and new test case.
>
>
> This addresses bug HIVE-4554.
>     https://issues.apache.org/jira/browse/HIVE-4554
>
>
> Diffs
> -----
>
>   data/files/person PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java bd8d252
>   ql/src/test/queries/clientpositive/load_file_with_space_in_the_name.q PRE-CREATION
>   ql/src/test/results/clientpositive/load_file_with_space_in_the_name.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11335/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Xuefu Zhang
>
>

+
Xuefu Zhang 2013-06-04, 18:32
+
Ashutosh Chauhan 2013-06-04, 19:06
+
Xuefu Zhang 2013-06-04, 21:51
+
Xuefu Zhang 2013-06-02, 13:51