Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Zookeeper, mail # dev - Review Request 15256: ZOOKEEPER-442: need a way to remove watches that are no longer of interest


Copy link to this message
-
Review Request 15256: ZOOKEEPER-442: need a way to remove watches that are no longer of interest
Rakesh R 2013-11-06, 02:20

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15256/
-----------------------------------------------------------

Review request for zookeeper, fpj and Mahadev Konar.
Bugs: ZOOKEEPER-442
    https://issues.apache.org/jira/browse/ZOOKEEPER-442
Repository: zookeeper
Description
-------

Added APIs to remove watches that are not needed anymore. If the removal completes successfully it is guaranteed that the watcher won't be notified.
Diffs
-----

  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java 1533155
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/KeeperException.java 1533155
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/WatchDeregistration.java PRE-CREATION
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/Watcher.java 1533155
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooDefs.java 1533155
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java 1533155
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataTree.java 1533155
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 1533155
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1533155
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/Request.java 1533155
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/WatchManager.java 1533155
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZKDatabase.java 1533155
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/RemoveWatchesTest.java PRE-CREATION
  http://svn.apache.org/repos/asf/zookeeper/trunk/src/zookeeper.jute 1533155

Diff: https://reviews.apache.org/r/15256/diff/
Testing
-------

Added unit test cases to see the client behaviors
Thanks,

Rakesh R

+
Rakesh R 2013-11-18, 17:33