Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://localhost:12000/sqoop'


Copy link to this message
-
Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://localhost:12000/sqoop'

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11535/#review21175
-----------------------------------------------------------

client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
<https://reviews.apache.org/r/11535/#comment44001>

    Is there a default port number constant? If not, I think it should be so that it can be referenced by other methods.

client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
<https://reviews.apache.org/r/11535/#comment44002>

    Is there a default webapp constant?
- Abraham Elmahrek
On May 30, 2013, 3:14 a.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11535/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 3:14 a.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 42577e8b5e2de3c987dfd99d462a4e766f617729
> Author: Mengwei Ding <[EMAIL PROTECTED]>
> Date:   Wed May 29 18:04:53 2013 -0700
>
>     SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://localhost:12000/sqoop'
>
> :100644 100644 8c3c6a4... e0956a0... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 1c85592... c2581c3... M client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java
> :100644 100644 f6d1267... 44007d1... M client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
> :100644 100644 c7a4cb3... 2a5eea4... M client/src/main/resources/client-resource.properties
>
>
> This addresses bug SQOOP-973.
>     https://issues.apache.org/jira/browse/SQOOP-973
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 8c3c6a4
>   client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java 1c85592
>   client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java f6d1267
>   client/src/main/resources/client-resource.properties c7a4cb3
>
> Diff: https://reviews.apache.org/r/11535/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>