Hi devs,

During our migration to 0.94.1 from 0.92.1 we encountered a problem.
Some of our code depends on HBaseConfiguration.create(Configuration)
to get a new configuration object that contained both the original
conf's and HBase's configurations. This behavior was changed in this
jira:

https://issues.apache.org/jira/browse/HBASE-5022

My understanding is that this optimization just removed the
HBase-specific bits and is now the equivalent of doing new
Configuration(Configuration). My question is: why do we keep this
method around? It's not doing anything that Configuration doesn't
already provide plus it's confusing since the other create() does add
the HBase configurations.

We should remove it and point to addHbaseResources or revert HBASE-5022.

Cheers,

J-D

bq. We should remove it and point to addHbaseResources or revert HBASE-5022.

I can create a new JIRA once N confirms the action to take.
I don't have preference.

On Wed, Aug 15, 2012 at 6:12 PM, Jean-Daniel Cryans <[EMAIL PROTECTED]>wrote:

> Hi devs,
>
> During our migration to 0.94.1 from 0.92.1 we encountered a problem.
> Some of our code depends on HBaseConfiguration.create(Configuration)
> to get a new configuration object that contained both the original
> conf's and HBase's configurations. This behavior was changed in this
> jira:
>
> https://issues.apache.org/jira/browse/HBASE-5022
>
> My understanding is that this optimization just removed the
> HBase-specific bits and is now the equivalent of doing new
> Configuration(Configuration). My question is: why do we keep this
> method around? It's not doing anything that Configuration doesn't
> already provide plus it's confusing since the other create() does add
> the HBase configurations.
>
> We should remove it and point to addHbaseResources or revert HBASE-5022.
>
> Cheers,
>
> J-D
>

On Wed, Aug 15, 2012 at 6:12 PM, Jean-Daniel Cryans <[EMAIL PROTECTED]> wrote:
> We should remove it and point to addHbaseResources or revert HBASE-5022.
>

We should revert HBASE-5022 and use new Configuration(Configuration)
whereever the perf issues shows.

N is on vacation so not around these times.  I'll take care of it.

St.Ack

Hi,

I added a comment in HBASE-5022. Reverting it seems to be the good
option. Sorry for the mistake.

Cheers,

Nicolas

On Thu, Aug 16, 2012 at 7:02 PM, Stack <[EMAIL PROTECTED]> wrote:
> On Wed, Aug 15, 2012 at 6:12 PM, Jean-Daniel Cryans <[EMAIL PROTECTED]> wrote:
>> We should remove it and point to addHbaseResources or revert HBASE-5022.
>>
>
> We should revert HBASE-5022 and use new Configuration(Configuration)
> whereever the perf issues shows.
>
> N is on vacation so not around these times.  I'll take care of it.
>
> St.Ack