Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hadoop >> mail # dev >> Help a newbie on patch submission


+
Mostafa Elhemali 2012-04-03, 16:12
+
Devaraj k 2012-04-03, 16:50
Copy link to this message
-
RE: Help a newbie on patch submission
Thanks Devaraj. I actually took care to convert the line endings to just LINE FEED (0A/^J) before submission, and I don't see ^M characters in either patch. I just opened the files in a binary editor to double-check and I don't see 0D anywhere.

-----Original Message-----
From: Devaraj k [mailto:[EMAIL PROTECTED]]
Sent: Tuesday, April 03, 2012 9:51 AM
To: [EMAIL PROTECTED]
Subject: RE: Help a newbie on patch submission

I tried applying your patches in my environment, It works fine.

The issue with Hadoop QA may be because of having <ctl>-M (^M) characters in the patch file. Can you try by removing the  <ctl>-M (^M) chars in the patch.

Thanks
Devaraj
________________________________________
From: Mostafa Elhemali [[EMAIL PROTECTED]]
Sent: Tuesday, April 03, 2012 9:42 PM
To: [EMAIL PROTECTED]
Subject: Help a newbie on patch submission

Hi,
I'm trying to submit a patch to fix some build problems in Hadoop trunk on Windows, and I'm having a hard time pleasing Hadoop QA. This is for Hadoop-8241 (https://issues.apache.org/jira/browse/HADOOP-8241). I submitted the first patch and it said it couldn't apply it, so I figured it may have to do with the fact that one of the two files fixed is in hadoop-hdfs-https which isn't part of the Hadoop Common project. So I submitted a second patch just for hadoop-dist/pom.xml which I believe is part of the Common project, but that couldn't be applied as well.
So I come to you: what am I doing horribly wrong and how can I appease the almighty Hadoop QA?

Thanks,
Mostafa Elhemali
+
Aaron T. Myers 2012-04-03, 17:19
+
Mostafa Elhemali 2012-04-03, 17:21