Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request: FLUME-1828: ResettableInputStream should support seek()


+
Mike Percy 2013-01-11, 09:56
+
Mike Percy 2013-01-12, 00:33
+
Mike Percy 2013-01-12, 00:34
+
Brock Noland 2013-01-12, 00:42
+
Brock Noland 2013-01-12, 01:18
+
Mike Percy 2013-01-14, 09:25
+
Brock Noland 2013-01-14, 17:37
+
Brock Noland 2013-01-14, 17:50
Copy link to this message
-
Re: Review Request: FLUME-1828: ResettableInputStream should support seek()
Mike Percy 2013-01-14, 18:58


> On Jan. 14, 2013, 5:37 p.m., Brock Noland wrote:
> > OK patch looks good. I will run tests.
>
> Brock Noland wrote:
>     Hey Mike,
>    
>     I think the latest patch is missing from the JIRA?
>    
>     Brock

Just uploaded it to the JIRA
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8926/#review15317
-----------------------------------------------------------
On Jan. 14, 2013, 9:25 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8926/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2013, 9:25 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> ResettableInputStream should support seek().
>
> This patch makes ResettableInputStream an abstract class instead of an interface, and adds a Seekable interface which is implemented by ResettableInputStream and its subclasses.
>
>
> This addresses bug FLUME-1828.
>     https://issues.apache.org/jira/browse/FLUME-1828
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java f9e4ec9
>   flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableInputStream.java ae989a6
>   flume-ng-core/src/main/java/org/apache/flume/serialization/Seekable.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestStringInputStream.java ef8b7ba
>   flume-ng-core/src/test/java/org/apache/flume/serialization/TestResettableFileInputStream.java 73e2baa
>
> Diff: https://reviews.apache.org/r/8926/diff/
>
>
> Testing
> -------
>
> Added unit test for seek(). Unit tests pass.
>
>
> Thanks,
>
> Mike Percy
>
>

+
Brock Noland 2013-01-14, 19:49