Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: HDFS Sink should check if file is closed and retry if it is not.


+
Ted Malaska 2013-05-31, 19:25
Copy link to this message
-
Re: Review Request: HDFS Sink should check if file is closed and retry if it is not.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11583/
-----------------------------------------------------------

(Updated May 31, 2013, 7:26 p.m.)
Review request for Flume.
Changes
-------

Updated AbstractHDFSWriter and it's children to use isFileClosed is it is available.
Also includes unit tests
Description
-------

We can use the new API added in HDFS-4525. We will need to use reflection though, so we can run against a version of HDFS which does not have this API.
This addresses bug 2007.
    https://issues.apache.org/jira/browse/2007
Diffs
-----

  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/AbstractHDFSWriter.java bc3b383
  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSCompressedDataStream.java 2c2be6a
  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSDataStream.java b8214be
  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSSequenceFile.java 0383744
  flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestUseRawLocalFileSystem.java ffbdde0

Diff: https://reviews.apache.org/r/11583/diff/
Testing
-------
Thanks,

Ted Malaska

+
Ted Malaska 2013-06-07, 19:56
+
Hari Shreedharan 2013-06-07, 18:09
+
Ted Malaska 2013-06-07, 18:52