Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Bigtop >> mail # dev >> Review Request: BIGTOP-836: Hue status on SuSE doesn't work when run from outside of /usr/bin


Copy link to this message
-
Re: Review Request: BIGTOP-836: Hue status on SuSE doesn't work when run from outside of /usr/bin


> On Jan. 30, 2013, 6:02 p.m., Roman Shaposhnik wrote:
> > bigtop-packages/src/rpm/hue/SOURCES/hue.init.suse, line 109
> > <https://reviews.apache.org/r/9155/diff/1/?file=253326#file253326line109>
> >
> >     I don't remember this off the top of my head, but does LSB explicitly cover the cases where program appears to be running but PID files is empty/absent?

I was referring to http://refspecs.linuxbase.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
I wasn't able to find any such reference that talked about program running but PID file being absent.
> On Jan. 30, 2013, 6:02 p.m., Roman Shaposhnik wrote:
> > bigtop-packages/src/rpm/hue/SOURCES/hue.init.suse, line 125
> > <https://reviews.apache.org/r/9155/diff/1/?file=253326#file253326line125>
> >
> >     given that it is a status of grep you're inspecting here I'd make it an explicit check against 0 as opposed to $STATUS_RUNNING

Agreed and will do.
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9155/#review15872
-----------------------------------------------------------
On Jan. 30, 2013, 7 a.m., Mark Grover wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9155/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 7 a.m.)
>
>
> Review request for bigtop and Roman Shaposhnik.
>
>
> Description
> -------
>
> See BIGTOP-836 for details
>
>
> This addresses bug BIGTOP-836.
>     https://issues.apache.org/jira/browse/BIGTOP-836
>
>
> Diffs
> -----
>
>   bigtop-packages/src/rpm/hue/SOURCES/hue.init.suse 7605285
>
> Diff: https://reviews.apache.org/r/9155/diff/
>
>
> Testing
> -------
>
> Tested status of hue when:
> 1. Hue was not running
> 2. Hue was successfully running
> 3. Hue was killed using init script
> 4. Hue was killed using kill -9
>
> Expected results were seen.
>
>
> Thanks,
>
> Mark Grover
>
>