Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-2036. Make hostname optional for HTTPSource


+
Hari Shreedharan 2013-05-07, 21:52
+
Mike Percy 2013-05-08, 20:36
Copy link to this message
-
Re: Review Request: FLUME-2036. Make hostname optional for HTTPSource


> On May 8, 2013, 8:36 p.m., Mike Percy wrote:
> > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java, line 30
> > <https://reviews.apache.org/r/10984/diff/1/?file=288642#file288642line30>
> >
> >     Changing the key name and then providing an open default value is a security risk on multi-homed hosts that should only listen on one interface.
> >    
> >     Let's either stick with host or prefer bind, then check for host, then go with the default.

Not sure what you mean by changing the key name? We just committed the "host" key yesterday. That never went into any release, so no one should really be running that in production.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10984/#review20342
-----------------------------------------------------------
On May 7, 2013, 9:52 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10984/
> -----------------------------------------------------------
>
> (Updated May 7, 2013, 9:52 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Made the hostname optional and added default of 0.0.0.0. Added docs and changed the host param to "bind" to match what we do in thrift and avro sources
>
>
> This addresses bug FLUME-2036.
>     https://issues.apache.org/jira/browse/FLUME-2036
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java a96fc0d
>   flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java e7b3c7a
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 83e96f5
>
> Diff: https://reviews.apache.org/r/10984/diff/
>
>
> Testing
> -------
>
> Ran full tests
>
>
> Thanks,
>
> Hari Shreedharan
>
>

+
Mike Percy 2013-05-08, 20:54
+
Mike Percy 2013-05-08, 22:19