Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Re: Review Request 10445: FLUME-1889 - Add HBASE and ASYNC_HBASE enum types to SinkType


Copy link to this message
-
Re: Review Request 10445: FLUME-1889 - Add HBASE and ASYNC_HBASE enum types to SinkType

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10445/#review23300
-----------------------------------------------------------

Ship it!
Looks good to me, thanks!

- Alexander Alten-Lorenz
On April 24, 2013, 11:35 a.m., Israel Ekpo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10445/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 11:35 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-1889 and FLUME-1994
>     https://issues.apache.org/jira/browse/FLUME-1889
>     https://issues.apache.org/jira/browse/FLUME-1994
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Modified SyncType and SinkConfiguration to support this improvement.
>
>
> Diffs
> -----
>
>   flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java c6c99d5
>   flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java 7e0288e
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSinkCreation.java PRE-CREATION
>   flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestHBaseSinkCreation.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10445/diff/
>
>
> Testing
> -------
>
> The unit tests added simulate how these sinks are loaded.
>
>
> Thanks,
>
> Israel Ekpo
>
>