Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 16727: Review Board for HIVE-5446 Hive can CREATE an external table but not SELECT from it when file path have spaces


Copy link to this message
-
Re: Review Request 16727: Review Board for HIVE-5446 Hive can CREATE an external table but not SELECT from it when file path have spaces

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16727/#review31338
-----------------------------------------------------------

ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java
<https://reviews.apache.org/r/16727/#comment59812>

    Don't we need to take care of this also? A partition can also be specified with an external location.

ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java
<https://reviews.apache.org/r/16727/#comment59815>

    1. Code isn't indented properly.
    2. LOG.info() can probably log more info than just the exception, something like "Failed to construct a Path object from table location ... Error message is ..."

ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java
<https://reviews.apache.org/r/16727/#comment59814>

    I don't know why we need to make change here. tblDir is already an instance of Path. If it has issue, that means it's not constructed correctly. We should fix that instead.
- Xuefu Zhang
On Jan. 8, 2014, 3:15 a.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16727/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 3:15 a.m.)
>
>
> Review request for hive, Thejas Nair and Xuefu Zhang.
>
>
> Bugs: HIVE-5446
>     https://issues.apache.org/jira/browse/HIVE-5446
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Hive cannot select from external table with location has "+" or space in the path
>
>
> Diffs
> -----
>
>   data/files/ext_test_space/folder+with PRE-CREATION
>   itests/qtest/pom.xml 119ddb5
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 0fe260d
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java 32d84ea
>   ql/src/test/queries/clientpositive/external_table_with_space_in_location_path.q PRE-CREATION
>   ql/src/test/results/clientpositive/external_table_with_space_in_location_path.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16727/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Shuaishuai Nie
>
>