Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo >> mail # dev >> [VOTE] Deprecate mock in 1.6.0

Copy link to this message
Re: [VOTE] Deprecate mock in 1.6.0
+1 for keeping a fast and easy (and well documented) mechanism for
debugging iterators. Perhaps the SortedMapiterator is the solution..but the
key words here are 'well documented'

-1 for continuing support a half implemented mock framework that we have to
maintain. It makes code maintenance very hard when you couldnt, for
instance in the 1.3 series, even create a MockBatchDeleter. As Chris
stated, I agree that using the mock in the past had users walking the line
too closely between unit and integration tests. With the mock, I could
write a bunch of fully valid tests against an iterator without the ability
to verify that compactions didn't negatively affect my results. Except for
being fast, the MAC mostly eliminates the need to use the mock for that
kind of test at all while it makes the tests more valid to an actual
runtime environment.

+1 for mocking framework to be used in relevant unit tests. There are times
when a quick and dirty mock is immensely useful and MAC is slow and way
overkill for those tasks. Perhaps it would be worth a ticket to investigate
replacing the current usages of mockAccumulo (I haven't looked in awhile)
with said mocking framework.

On Nov 15, 2013 3:29 PM, "Michael Berman" <[EMAIL PROTECTED]> wrote:
> +1 (not really a voter)
> I think iterator unit tests should use SortedMapIterator, not anything
> a full accumulo stack, and I think MAC is far more suitable for
> tests because it actually runs the same code...it's impossible for an
> outsider to tell in which behaviors mock reflects actual accumulo and in
> which it does something totally different.
> I do think MAC needs some help, but I think the process of excising mock
> from our own tests will flesh out what we need there better than anything
> else we could do.
> On Thu, Nov 14, 2013 at 9:20 PM, <[EMAIL PROTECTED]> wrote:
> > +1
> >
> >
> >
> > *From:* Keith Turner [mailto:[EMAIL PROTECTED]]
> > *Sent:* Thursday, November 14, 2013 3:42 PM
> > *Subject:* [VOTE] Deprecate mock in 1.6.0
> >
> >
> >
> > Should we deprecate mock accumulo for 1.6.0?  This was considered [1]
> > 1.5.0.  I started thinking about this because I never added conditional
> > writer to mock.
> >
> >
> >
> > [1] : https://issues.apache.org/jira/browse/ACCUMULO-878
> >