Shall we commit the patch at
https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?

I reviewed it and its high-quality, with lots of new tests, and an
attention to self-migration (which it does) that is heartening.

I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
patch rots our on JIRA.

What you lot think?

St.Ack

I think this should go to 0.92

On Jul 26, 2011, at 7:17 PM, Stack <[EMAIL PROTECTED]> wrote:

> Shall we commit the patch at
> https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>
> I reviewed it and its high-quality, with lots of new tests, and an
> attention to self-migration (which it does) that is heartening.
>
> I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
> patch rots our on JIRA.
>
> What you lot think?
>
> St.Ack

+1

It's a big patch but has seen much more testing than the typical and is of high quality as you mention. Earlier rather than later I'd say. But then let's let 0.92 bake with it sufficiently.
 
Best regards,
   - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
>________________________________
>From: Stack <[EMAIL PROTECTED]>
>To: HBase Dev List <[EMAIL PROTECTED]>
>Sent: Tuesday, July 26, 2011 7:17 PM
>Subject: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
>
>Shall we commit the patch at
>https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>
>I reviewed it and its high-quality, with lots of new tests, and an
>attention to self-migration (which it does) that is heartening.
>
>I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
>patch rots our on JIRA.
>
>What you lot think?
>
>St.Ack
>
>
>

This increases the efficiency of a hbase cluster tremendously. +1 for
committing it earlier rather than later.

-dhruba

On Tue, Jul 26, 2011 at 7:29 PM, Andrew Purtell <[EMAIL PROTECTED]> wrote:

> +1
>
> It's a big patch but has seen much more testing than the typical and is of
> high quality as you mention. Earlier rather than later I'd say. But then
> let's let 0.92 bake with it sufficiently.
>
> Best regards,
>
>
>    - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
>
>
> >________________________________
> >From: Stack <[EMAIL PROTECTED]>
> >To: HBase Dev List <[EMAIL PROTECTED]>
> >Sent: Tuesday, July 26, 2011 7:17 PM
> >Subject: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
> >
> >Shall we commit the patch at
> >https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
> >
> >I reviewed it and its high-quality, with lots of new tests, and an
> >attention to self-migration (which it does) that is heartening.
> >
> >I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
> >patch rots our on JIRA.
> >
> >What you lot think?
> >
> >St.Ack
> >
> >
> >
>

--
Connect to me at http://www.facebook.com/dhruba

+1 to 0.92 as well.

On Tue, Jul 26, 2011 at 9:59 PM, Dhruba Borthakur <[EMAIL PROTECTED]> wrote:
> This increases the efficiency of a hbase cluster tremendously. +1 for
> committing it earlier rather than later.
>
> -dhruba
>
> On Tue, Jul 26, 2011 at 7:29 PM, Andrew Purtell <[EMAIL PROTECTED]> wrote:
>
>> +1
>>
>> It's a big patch but has seen much more testing than the typical and is of
>> high quality as you mention. Earlier rather than later I'd say. But then
>> let's let 0.92 bake with it sufficiently.
>>
>> Best regards,
>>
>>
>>    - Andy
>>
>> Problems worthy of attack prove their worth by hitting back. - Piet Hein
>> (via Tom White)
>>
>>
>> >________________________________
>> >From: Stack <[EMAIL PROTECTED]>
>> >To: HBase Dev List <[EMAIL PROTECTED]>
>> >Sent: Tuesday, July 26, 2011 7:17 PM
>> >Subject: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
>> >
>> >Shall we commit the patch at
>> >https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>> >
>> >I reviewed it and its high-quality, with lots of new tests, and an
>> >attention to self-migration (which it does) that is heartening.
>> >
>> >I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
>> >patch rots our on JIRA.
>> >
>> >What you lot think?
>> >
>> >St.Ack
>> >
>> >
>> >
>>
>
>
>
> --
> Connect to me at http://www.facebook.com/dhruba
>

+1 for 0.92. This has received a lot of testing and code review internally. We have already found/fixed a number of advanced bugs before even submitting the initial patch. Very high quality.

On Jul 26, 2011, at 7:18 PM, "Stack" <[EMAIL PROTECTED]> wrote:

> Shall we commit the patch at
> https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>
> I reviewed it and its high-quality, with lots of new tests, and an
> attention to self-migration (which it does) that is heartening.
>
> I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
> patch rots our on JIRA.
>
> What you lot think?
>
> St.Ack

+1 to the idea of putting it in. I'm going to try to do a code review
tonight. If we could hold off a day or so to commit I'd appreciate it... but
if other stuff is blocked on it, go ahead whenever IMO.

On Tue, Jul 26, 2011 at 11:25 PM, Nicolas Spiegelberg
<[EMAIL PROTECTED]>wrote:

> +1 for 0.92. This has received a lot of testing and code review internally.
> We have already found/fixed a number of advanced bugs before even submitting
> the initial patch. Very high quality.
>
> On Jul 26, 2011, at 7:18 PM, "Stack" <[EMAIL PROTECTED]> wrote:
>
> > Shall we commit the patch at
> > https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
> >
> > I reviewed it and its high-quality, with lots of new tests, and an
> > attention to self-migration (which it does) that is heartening.
> >
> > I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
> > patch rots our on JIRA.
> >
> > What you lot think?
> >
> > St.Ack
>

--
Todd Lipcon
Software Engineer, Cloudera

+1 for 0.92

> -----Original Message-----
> From: Todd Lipcon [mailto:[EMAIL PROTECTED]]
> Sent: Tuesday, July 26, 2011 11:27 PM
> To: [EMAIL PROTECTED]
> Subject: Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
>
> +1 to the idea of putting it in. I'm going to try to do a code review
> tonight. If we could hold off a day or so to commit I'd appreciate it... but if
> other stuff is blocked on it, go ahead whenever IMO.
>
> On Tue, Jul 26, 2011 at 11:25 PM, Nicolas Spiegelberg
> <[EMAIL PROTECTED]>wrote:
>
> > +1 for 0.92. This has received a lot of testing and code review internally.
> > We have already found/fixed a number of advanced bugs before even
> > submitting the initial patch. Very high quality.
> >
> > On Jul 26, 2011, at 7:18 PM, "Stack" <[EMAIL PROTECTED]> wrote:
> >
> > > Shall we commit the patch at
> > > https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
> > >
> > > I reviewed it and its high-quality, with lots of new tests, and an
> > > attention to self-migration (which it does) that is heartening.
> > >
> > > I'm +1 on committing it now to TRUNK in time for 0.92 before this
> > > fat patch rots our on JIRA.
> > >
> > > What you lot think?
> > >
> > > St.Ack
> >
>
>
>
> --
> Todd Lipcon
> Software Engineer, Cloudera

+1

On Tue, Jul 26, 2011 at 7:17 PM, Stack <[EMAIL PROTECTED]> wrote:
> Shall we commit the patch at
> https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>
> I reviewed it and its high-quality, with lots of new tests, and an
> attention to self-migration (which it does) that is heartening.
>
> I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
> patch rots our on JIRA.
>
> What you lot think?
>
> St.Ack
>

This vote has carried.
 
Best regards,
   - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
>________________________________
>From: Jean-Daniel Cryans <[EMAIL PROTECTED]>
>To: [EMAIL PROTECTED]
>Sent: Wednesday, July 27, 2011 11:36 AM
>Subject: Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
>
>+1
>
>On Tue, Jul 26, 2011 at 7:17 PM, Stack <[EMAIL PROTECTED]> wrote:
>> Shall we commit the patch at
>> https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>>
>> I reviewed it and its high-quality, with lots of new tests, and an
>> attention to self-migration (which it does) that is heartening.
>>
>> I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
>> patch rots our on JIRA.
>>
>> What you lot think?
>>
>> St.Ack
>>
>
>
>

Will apply after Todd finishes his review.
St.Ack
On Wed, Jul 27, 2011 at 1:19 PM, Andrew Purtell <[EMAIL PROTECTED]> wrote:
> This vote has carried.
>
> Best regards,
>
>
>    - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
>
>
>>________________________________
>>From: Jean-Daniel Cryans <[EMAIL PROTECTED]>
>>To: [EMAIL PROTECTED]
>>Sent: Wednesday, July 27, 2011 11:36 AM
>>Subject: Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
>>
>>+1
>>
>>On Tue, Jul 26, 2011 at 7:17 PM, Stack <[EMAIL PROTECTED]> wrote:
>>> Shall we commit the patch at
>>> https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
>>>
>>> I reviewed it and its high-quality, with lots of new tests, and an
>>> attention to self-migration (which it does) that is heartening.
>>>
>>> I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
>>> patch rots our on JIRA.
>>>
>>> What you lot think?
>>>
>>> St.Ack
>>>
>>
>>
>>

Review finished. Looks great! Just a few minor touch-ups I mentioned on RB.

On Wed, Jul 27, 2011 at 1:24 PM, Stack <[EMAIL PROTECTED]> wrote:

> Will apply after Todd finishes his review.
> St.Ack
>
>
> On Wed, Jul 27, 2011 at 1:19 PM, Andrew Purtell <[EMAIL PROTECTED]>
> wrote:
> > This vote has carried.
> >
> > Best regards,
> >
> >
> >    - Andy
> >
> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
> >
> >
> >>________________________________
> >>From: Jean-Daniel Cryans <[EMAIL PROTECTED]>
> >>To: [EMAIL PROTECTED]
> >>Sent: Wednesday, July 27, 2011 11:36 AM
> >>Subject: Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?
> >>
> >>+1
> >>
> >>On Tue, Jul 26, 2011 at 7:17 PM, Stack <[EMAIL PROTECTED]> wrote:
> >>> Shall we commit the patch at
> >>> https://issues.apache.org/jira/browse/HBASE-3857 for 0.92?
> >>>
> >>> I reviewed it and its high-quality, with lots of new tests, and an
> >>> attention to self-migration (which it does) that is heartening.
> >>>
> >>> I'm +1 on committing it now to TRUNK in time for 0.92 before this fat
> >>> patch rots our on JIRA.
> >>>
> >>> What you lot think?
> >>>
> >>> St.Ack
> >>>
> >>
> >>
> >>
>

--
Todd Lipcon
Software Engineer, Cloudera