Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig, mail # dev - Review Request: PIG-3223 AvroStorage does not handle comma separated input paths


Copy link to this message
-
Re: Review Request: PIG-3223 AvroStorage does not handle comma separated input paths
Rohini Palaniswamy 2013-05-03, 18:53

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10351/#review20127
-----------------------------------------------------------

contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java
<https://reviews.apache.org/r/10351/#comment41387>

    Can you move these comments to inside the method or remove them as they can be seen from the code. Should not be part of the java doc

contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java
<https://reviews.apache.org/r/10351/#comment41384>

    for (FileStatus file : matchedFiles) {
      getAllSubDirsInternal(file.getPath, conf, paths, fs);
    }

contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java
<https://reviews.apache.org/r/10351/#comment41385>

    private

contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java
<https://reviews.apache.org/r/10351/#comment41386>

     getAllSubDirsInternal(sub.getPath(), conf, paths, fs)
    
    Doing fs.listStatus(file.getPath()) twice is redundant
- Rohini Palaniswamy
On May 3, 2013, 12:33 a.m., Johnny Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10351/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 12:33 a.m.)
>
>
> Review request for pig.
>
>
> Description
> -------
>
> we want to support comma separated input paths in AvroStorage, for example
> "test_dir1/test_glob1.avro,test_dir1/test_glob2.avro,test_dir1/test_glob3.avro"
> "test_dir1/*, test_dir2/test_glob4.avro, test_dir2/test_glob5.avro"
>
>
> This addresses bug PIG-3223.
>     https://issues.apache.org/jira/browse/PIG-3223
>
>
> Diffs
> -----
>
>   contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 0ac0225
>   contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java bd7a6d2
>
> Diff: https://reviews.apache.org/r/10351/diff/
>
>
> Testing
> -------
>
> added two more test cases in TestAvroStorage.java and they all pass
>
>
> Thanks,
>
> Johnny Zhang
>
>