Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-818 Missing method setConnManager(Lcom/cloudera/sqoop/manager/ConnManager; )V in ExportJobContContext breaks MS SQL Connector


Copy link to this message
-
Re: Review Request: SQOOP-818 Missing method setConnManager(Lcom/cloudera/sqoop/manager/ConnManager; )V in ExportJobContContext breaks MS SQL Connector
Cheolsoo Park 2013-01-08, 18:13

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8892/#review15148
-----------------------------------------------------------

Ship it!
Ship It!

- Cheolsoo Park
On Jan. 8, 2013, 3:32 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8892/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2013, 3:32 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've added missing method and one missing public inner class.
>
>
> This addresses bug SQOOP-818.
>     https://issues.apache.org/jira/browse/SQOOP-818
>
>
> Diffs
> -----
>
>   src/java/com/cloudera/sqoop/manager/ExportJobContext.java 552f346
>   src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java dba4a49
>
> Diff: https://reviews.apache.org/r/8892/diff/
>
>
> Testing
> -------
>
> * SQOOP-820 is needed in order to properly test this
> * I've verified on ThirdParty tests that the connector is working using following command:
>
> ant clean test '-Dtestcase=SQLServerManager*' -Dsqoop.test.sqlserver.connectstring.host_url=jdbc:sqlserver://<IP>:1433 -Dsqoop.test.msserver.connector.factory=com.microsoft.sqoop.SqlServer.MSSQLServerManagerFactory
>
> Please note that 2 test are expected to fail as they are testing custom schema support that Connector from Microsoft do not have at the moment, namely:
>
> * SQLServerManagerExportManualTest.testExportCustomSchema()
> * SQLServerManagerImportManualTest.testImportDifferentSchema()
>
>
> Thanks,
>
> Jarek Cecho
>
>