Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: FLUME-1502: Support for running simple configurations embedded in host process


Copy link to this message
-
Re: Review Request: FLUME-1502: Support for running simple configurations embedded in host process
Brock Noland 2012-12-09, 17:47


> On Dec. 9, 2012, 12:24 a.m., Mike Percy wrote:
> > flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java, line 242
> > <https://reviews.apache.org/r/8127/diff/1/?file=221801#file221801line242>
> >
> >     Why add these public methods to AvroSource?

This is to support the put, putAll methods on the embedded agent. We've decided against allowing AvroSource so this can be removed.
> On Dec. 9, 2012, 12:24 a.m., Mike Percy wrote:
> > flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java, line 75
> > <https://reviews.apache.org/r/8127/diff/1/?file=221805#file221805line75>
> >
> >     Should we add
> >    
> >       @InterfaceAudience.Public
> >       @InterfaceStability.Stable
> >    
> >     to this constructor?

The class is marked Public and Stable as such that applies to all methods unless specified otherwise.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/#review14085
-----------------------------------------------------------
On Nov. 19, 2012, 7:42 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8127/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 7:42 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch is on top of the FLUME-1502 branch which has 1630 committed to it.
>
> This patch creates a module flume-ng-embedded-agent which implements FLUME-1502. The patch is not read for commit. Specifically, it needs the following:
>
> 1) whitespace removal
> 2) docs in package-info.java and the developer guide
>
> However, I'd like to start soliciting feedback as these are not items which will affect it's overall design.
>
>
> This addresses bug FLUME-1502.
>     https://issues.apache.org/jira/browse/FLUME-1502
>
>
> Diffs
> -----
>
>   flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 9b209e8
>   flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java f39b919
>   flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 47ccf9f
>   flume-ng-dist/pom.xml d929c88
>   flume-ng-embedded-agent/pom.xml PRE-CREATION
>   flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/AvroLocalSource.java PRE-CREATION
>   flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java PRE-CREATION
>   flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java PRE-CREATION
>   flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java PRE-CREATION
>   flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/LocalSource.java PRE-CREATION
>   flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java PRE-CREATION
>   flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java PRE-CREATION
>   flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java PRE-CREATION
>   flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentAvroSource.java PRE-CREATION
>   flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java PRE-CREATION
>   flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java PRE-CREATION
>   flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java PRE-CREATION
>   flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION
>   pom.xml 76b8351
>
> Diff: https://reviews.apache.org/r/8127/diff/
>
>
> Testing
> -------
>
> Additional unit tests have been added and they pass.