Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Zookeeper, mail # dev - Review Request: ZOOKEEPER-1147: Add support for local sessions


+
Thawan Kooburat 2013-01-12, 04:27
+
Thawan Kooburat 2013-01-14, 23:48
Copy link to this message
-
Re: Review Request: ZOOKEEPER-1147: Add support for local sessions
Edward Ribeiro 2013-01-24, 21:49

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8935/#review15654
-----------------------------------------------------------

/src/java/main/org/apache/zookeeper/cli/CreateCommand.java
<https://reviews.apache.org/r/8935/#comment33773>

    Wouldn't be the case of adding a "return false" after line 81?
- Edward Ribeiro
On Jan. 14, 2013, 11:48 p.m., Thawan Kooburat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8935/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2013, 11:48 p.m.)
>
>
> Review request for zookeeper, Patrick Hunt and Mahadev Konar.
>
>
> Description
> -------
>
> See ZOOKEEPER-1147 for high level description
>
> Implementation notes:
>
> - Local sessions don’t get persisted on disk.  Existing SessionTrackerImpl is used by the leader to track global sessions.  Each participant (including the leader) also has a local session tracker (which is another instance of SessionTrackerImpl) to track its local session in memory.
>
> - Each participant intercepts a request before it enters the pipeline. In order to do 2 things
>  o Update local session to global session when it saw create ephemeral node request. Update is done by issuing a create session rquest before issuing the create request
>  o Add local session flag to a request. So that the pipeline know that this type of request don’t need to send to the leader and wait for commit
>
> - PrepRequestProcessor (on the leader) now explicitly validate global session on create ephemeral node request.  For other type of request, there is no need for session validation because the leader doesn’t know about local sessions on other machine, so the request has to go through.  The correctness is preserve as long a no ephemeral node is created after session is already expired
>
> - Observer/FollowerRequestProcessor has logic to validate session. However, I believe this logic is in correct since the request is already send downstream to the CommitProcessor. The observer and the follower have no other option but to send the request to leader.
>
>
> This addresses bug ZOOKEEPER-1147.
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1147
>
>
> Diffs
> -----
>
>   /src/java/main/org/apache/zookeeper/KeeperException.java 1427034
>   /src/java/main/org/apache/zookeeper/cli/CreateCommand.java 1427034
>   /src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 1427034
>   /src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1427034
>   /src/java/main/org/apache/zookeeper/server/Request.java 1427034
>   /src/java/main/org/apache/zookeeper/server/SessionTracker.java 1427034
>   /src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1427034
>   /src/java/main/org/apache/zookeeper/server/TraceFormatter.java 1427034
>   /src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1427034
>   /src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1427034
>   /src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1427034
>   /src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java PRE-CREATION
>   /src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1427034
>   /src/java/main/org/apache/zookeeper/server/quorum/Learner.java 1427034
>   /src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1427034
>   /src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 1427034
>   /src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java 1427034
>   /src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java PRE-CREATION
>   /src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1427034
>   /src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java 1427034
+
Thawan Kooburat 2013-01-28, 08:00
+
Edward Ribeiro 2013-01-27, 23:58
+
Thawan Kooburat 2013-01-28, 08:00
+
Thawan Kooburat 2013-02-20, 01:00
+
Thawan Kooburat 2013-02-20, 02:20
+
Thawan Kooburat 2013-03-02, 20:03
+
Thawan Kooburat 2013-03-06, 23:42
+
Edward Ribeiro 2013-03-23, 01:07
+
Edward Ribeiro 2013-03-23, 00:57
+
Edward Ribeiro 2013-03-22, 23:54
+
Edward Ribeiro 2013-03-23, 01:00
+
Edward Ribeiro 2013-03-22, 23:59
+
Edward Ribeiro 2013-03-22, 23:42
+
Edward Ribeiro 2013-03-22, 23:41
+
Edward Ribeiro 2013-03-22, 23:23
+
Thawan Kooburat 2013-04-24, 01:31