Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 14155: HIVE-5297 Hive does not honor type for partition columns


Copy link to this message
-
Re: Review Request 14155: HIVE-5297 Hive does not honor type for partition columns
Sergey Shelukhin 2013-09-16, 23:19

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14155/#review26159
-----------------------------------------------------------

common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/14155/#comment51110>

    why false by default?

ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/14155/#comment51111>

    nit: the return seems pointless, it always returns the same map that caller already has

ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/14155/#comment51112>

    wouldn't it re-put the entire map into itself as it stands now

ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/14155/#comment51113>

    not really familiar with this flavor of trees; is val guaranteed to be the 2nd argument? Can it be reverse.
    Also nit above - checks for 0 children but not for 1.

ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/14155/#comment51114>

    nit: use entrySet?

ql/src/test/queries/clientnegative/illegal_partition_type.q
<https://reviews.apache.org/r/14155/#comment51115>

    local path, also below in other q files
- Sergey Shelukhin
On Sept. 16, 2013, 9:05 p.m., Vikram Dixit Kumaraswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14155/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2013, 9:05 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-5297
>     https://issues.apache.org/jira/browse/HIVE-5297
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Hive does not consider the type of the partition column while writing partitions. Consider for example the query:
>
> create table tab1 (id1 int, id2 string) PARTITIONED BY(month string,day int) row format delimited fields terminated by ',';
> alter table tab1 add partition (month='June', day='second');
>
> Hive accepts this query. However if you try to select from this table and insert into another expecting schema match, it will insert nulls instead.
>
>
> Diffs
> -----
>
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1af68a6
>   ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 393ef57
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 2ece97e
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java a704462
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g ca667d4
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 767f545
>   ql/src/test/queries/clientnegative/illegal_partition_type.q PRE-CREATION
>   ql/src/test/queries/clientnegative/illegal_partition_type2.q PRE-CREATION
>   ql/src/test/queries/clientpositive/partition_type_check.q PRE-CREATION
>   ql/src/test/results/clientnegative/illegal_partition_type.q.out PRE-CREATION
>   ql/src/test/results/clientnegative/illegal_partition_type2.q.out PRE-CREATION
>   ql/src/test/results/clientpositive/parititon_type_check.q.out PRE-CREATION
>   ql/src/test/results/clientpositive/partition_type_check.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14155/diff/
>
>
> Testing
> -------
>
> Ran all tests.
>
>
> Thanks,
>
> Vikram Dixit Kumaraswamy
>
>