Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Re: Review Request 14887: Subquery support: disallow nesting of SubQueries


Copy link to this message
-
Re: Review Request 14887: Subquery support: disallow nesting of SubQueries
Harish Butani 2013-10-29, 18:43

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14887/
-----------------------------------------------------------

(Updated Oct. 29, 2013, 6:43 p.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------

fix -ve test subquery_subquery_chain.q
Add check when building SubQuery Object: SubQuery AST must not contain a child SubQuery AST
Bugs: HIVE-5613
    https://issues.apache.org/jira/browse/HIVE-5613
Repository: hive-git
Description
-------

This is Restriction 9 from the SubQuery design doc:
We will not do algebraic transformations for these kinds of queries:

{noformat}
-query 1
select ...
from x
where  
    x.b in (select u
            from y
            where y.c = 10 and
                  exists (select m from z where z.A = x.C)
           )
- query 2
select ...
from x
where  
    x.b in (select u
            from y
            where y.c = 10 and
                  exists (select m from z where z.A = y.D)
{noformat}
Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 50b5a77
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cf0c895
  ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 2d7775c
  ql/src/test/queries/clientnegative/subquery_nested_subquery.q PRE-CREATION
  ql/src/test/results/clientnegative/subquery_nested_subquery.q.out PRE-CREATION
  ql/src/test/results/clientnegative/subquery_subquery_chain.q.out 2eadfc3

Diff: https://reviews.apache.org/r/14887/diff/
Testing
-------

tested subquery tests
added new subquery_nested_subquery.q negative test
Thanks,

Harish Butani