Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig, mail # dev - Re: Review Request: PIG-3331 Default values not written to Schema when specified in the output schema


Copy link to this message
-
Re: Review Request: PIG-3331 Default values not written to Schema when specified in the output schema
Viraj Bhat 2013-06-04, 21:52


> On June 3, 2013, 1:20 p.m., Rohini Palaniswamy wrote:
> > http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java, lines 629-636
> > <https://reviews.apache.org/r/11355/diff/2/?file=295976#file295976line629>
> >
> >     Isn't a load and store enough to reproduce the test case? Why such a long pig script? Please try to keep the unit tests simple.

Made a smaller script to test it.
- Viraj
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11355/#review21315
-----------------------------------------------------------
On June 4, 2013, 9:50 p.m., Viraj Bhat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11355/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 9:50 p.m.)
>
>
> Review request for pig and Rohini Palaniswamy.
>
>
> Description
> -------
>
> Patch to write default values to the Schema when the writer schema contains that in the AvroStorage.
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigSchema2Avro.java 1485826
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1485826
>
> Diff: https://reviews.apache.org/r/11355/diff/
>
>
> Testing
> -------
>
> Yes against the Piggybank  in Pig trunk/Pig 0.12
>
>
> Thanks,
>
> Viraj Bhat
>
>