Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo, mail # dev - Re: Review Request 15846: Prototype implementation of ACCUMULO-1787.


Copy link to this message
-
Re: Review Request 15846: Prototype implementation of ACCUMULO-1787.
Chris McCubbin 2013-12-02, 14:21


> On Nov. 26, 2013, 2:32 p.m., kturner wrote:
> > server/src/main/java/org/apache/accumulo/server/tabletserver/Compactor.java, line 300
> > <https://reviews.apache.org/r/15846/diff/2/?file=391121#file391121line300>
> >
> >     The following situation is kinda bugging me, but I do not think its very important.
> >    
> >     1. some snappy files exceed threshold
> >     2. creates a gzip file thats below threshold
> >     3. forced compaction of that gzip file creates a snappy file
> >    
> >    
> >    
> >

I had actually thought about this as a potential issue as well. Can it actually happen though? Can the gzip file below the threshold be compacted again without combining with another file?
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15846/#review29433
-----------------------------------------------------------
On Nov. 26, 2013, 4:32 a.m., Chris McCubbin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15846/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2013, 4:32 a.m.)
>
>
> Review request for accumulo, Adam Fuchs, Josh Elser, and kturner.
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> This is a prototype implementation of ACCUMULO-1787.
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java f4c1778
>   server/src/main/java/org/apache/accumulo/server/tabletserver/Compactor.java 8e4af64
>
> Diff: https://reviews.apache.org/r/15846/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris McCubbin
>
>