Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-648 Moving localizable strings to resources and consolidate all String constants to Constants.java


+
Venkat Ranganathan 2012-12-01, 16:49
+
Venkat Ranganathan 2012-12-02, 06:11
+
Venkat Ranganathan 2012-12-02, 06:49
+
Jarek Cecho 2012-12-02, 17:07
+
Jarek Cecho 2012-12-03, 18:11
+
Venkat Ranganathan 2012-12-03, 18:04
+
Venkat Ranganathan 2012-12-05, 07:56
+
Venkat Ranganathan 2012-12-05, 18:41
+
Venkat Ranganathan 2012-12-08, 17:58
+
Jarek Cecho 2012-12-08, 18:57
Copy link to this message
-
Re: Review Request: SQOOP-648 Moving localizable strings to resources and consolidate all String constants to Constants.java
Jarek Cecho 2012-12-08, 15:59

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8305/#review14220
-----------------------------------------------------------
Hi Venkat,
thank you very much for your quick feedback and please accept my apology for late review. It looks good to me and I'm ready to get it in. The patch seems to be not applying cleanly on current Sqoop2 branch. I think that it's because we've add version to connector component in SQOOP-739. Would you mind rebasing your patch? I'll commit it soon after that.

Jarcec

- Jarek Cecho
On Dec. 5, 2012, 6:41 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8305/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2012, 6:41 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> I have moved localizable strings to the client resources (those that are descriptions, messages in general etc).  Also consolidated constants to one place and removed repetitive occurrences.  
>
> 4 more files in utils need to be updated, but wanted to get this reviewed and take that after this
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 47c0547
>   client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java 847a6ad
>   client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java 21c41aa
>   client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java b0e8d90
>   client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java 2453543
>   client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 734276d
>   client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java 0b685bf
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteCommand.java bb09bf3
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java ee2a1cf
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java acc8e21
>   client/src/main/java/org/apache/sqoop/client/shell/HelpCommand.java 03499d8
>   client/src/main/java/org/apache/sqoop/client/shell/SetCommand.java 20c8090
>   client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 3764306
>   client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java daf1ff4
>   client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java bd74253
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 4e49288
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java ac2683c
>   client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java 8dcf976
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java ee8c63d
>   client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java 039e28b
>   client/src/main/java/org/apache/sqoop/client/shell/ShowVersionFunction.java 9e8c607
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopCommand.java 9ae693e
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java 200b3ee
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java b2d05f4
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java 39a2b31
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 74ce905
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 4d683c0
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java 97628f7
>   client/src/main/java/org/apache/sqoop/client/shell/UpdateCommand.java 5bac209
>   client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java 4e55dba
>   client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java f7cdf26
+
Jarek Cecho 2012-12-05, 16:09
+
Jarek Cecho 2012-12-01, 18:49