Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hadoop >> mail # dev >> [DISCUSS] What is the purpose of merge vote threads?


Copy link to this message
-
Re: [DISCUSS] What is the purpose of merge vote threads?
On Fri, Oct 25, 2013 at 9:35 AM, Suresh Srinivas <[EMAIL PROTECTED]> wrote:
> Granted some of the feature readiness activity can be done during voting.
> But I fail to understand why expediting a feature that takes months to build
> should try to optimize a week. Why not finish the requirements we have for
> every patch for feature branch also?

I agree that requirements should not be relaxed.  But different clocks
can be used for different kinds of concerns.  For example, compiler
warnings should be addressed before commit but probably shouldn't
require restarting a week-long vote.  The point of the week is to give
folks ample time to review a patch.  Once concerns raised are
addressed to the satisfaction of those who've raised them why would
more time be required?  However if someone asks for more time to
review because the changes they requested are not easily reviewable in
the time remaining then they should be given that time.  Lastly, if
syncing a branch with trunk is difficult as trunk changes, then there
may be costs to delaying and we shouldn't delay without reason.

Doug