Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: Sqoop2: Help option for shell command functions


Copy link to this message
-
Re: Review Request: Sqoop2: Help option for shell command functions
rj.vasanthkumar@... 2013-03-29, 20:43


> On March 26, 2013, 2:59 a.m., Abraham Elmahrek wrote:
> > client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java, line 39
> > <https://reviews.apache.org/r/10100/diff/2/?file=274120#file274120line39>
> >
> >     protected final String?

Hi Abraham,

Thank you very much for your review comments. Kindly have a look in JIRA sqoop-965 comments for help option implementation. I am still waiting for which way to follow. I will fix your comments if this way of help option is planning to use.
- vasanthkumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10100/#review18375
-----------------------------------------------------------
On March 24, 2013, 8:46 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10100/
> -----------------------------------------------------------
>
> (Updated March 24, 2013, 8:46 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> There is no help option for shell command's functions. Introducing the help argument for functions.
>
>
> This addresses bug sqoop-965.
>     https://issues.apache.org/jira/browse/sqoop-965
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java cc80df1
>   client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java 0538901
>   client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java 6f62813
>   client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java 5bf9aaa
>   client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java f5155d5
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java 18d3a70
>   client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java 736be20
>   client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java 9414b7d
>   client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java 1c85592
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java 4fe20c1
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java 19a8123
>   client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java d37b73a
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 5505d51
>   client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java 890ede1
>   client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java 110f67e
>   client/src/main/java/org/apache/sqoop/client/shell/ShowVersionFunction.java 1038116
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java bf26761
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java cefe0a2
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 48db8ab
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java 8291a54
>   client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java 95ada63
>   client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java 3f0ac7d
>   client/src/main/resources/client-resource.properties 734333e
>   docs/src/site/sphinx/CommandLineClient.rst 1b9676f
>
> Diff: https://reviews.apache.org/r/10100/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>