Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1702 HDFSEventSink should write to a hidden file as opposed to a .tmp file


+
Jarek Cecho 2012-12-10, 02:20
+
Brock Noland 2012-12-13, 19:03
Copy link to this message
-
Re: Review Request: FLUME-1702 HDFSEventSink should write to a hidden file as opposed to a .tmp file


> On Dec. 13, 2012, 7:03 p.m., Brock Noland wrote:
> > I am seeing a test failure with this patch:
> >
> >
> > Tests in error:
> >   testIntervalRollerBug(org.apache.flume.sink.hdfs.TestBucketWriter): String index out of range: -20
> >
> >

Jarcec,

Otherwise the patch looks good! Thank you for your contribution!

Brock
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8438/#review14454
-----------------------------------------------------------
On Dec. 10, 2012, 2:20 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8438/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2012, 2:20 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> I've added two additional HDFS sink properties "inUsePrefix" and "inUseSuffix" allowing user to override both prefix and suffix of temporal files.
>
>
> This addresses bug FLUME-1702.
>     https://issues.apache.org/jira/browse/FLUME-1702
>
>
> Diffs
> -----
>
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 21ca5cc62450932f334d933e9ed50d224e10249a
>   flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java d0ff6e34399886ee4a85d983243f76899a966b79
>   flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 64ac2d73520be961617e3dd22b862305e4e00573
>   flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java b191ef3fd36be6cc4d8f754bb2ad9898994df03f
>   flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java d23f09dd9e8ef5c257bdb3b08bf8deec57641b0b
>
> Diff: https://reviews.apache.org/r/8438/diff/
>
>
> Testing
> -------
>
> Current unit tests seems to be passing. I've also added two additional tests to verify new functionality.
>
>
> Thanks,
>
> Jarek Cecho
>
>

+
Jarek Cecho 2012-12-16, 07:03
+
Brock Noland 2012-12-18, 20:05