Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: Request to review patch for SQOOP-954: Create Sqoop runtime scripts to run Sqoop on Windows


Copy link to this message
-
Re: Review Request: Request to review patch for SQOOP-954: Create Sqoop runtime scripts to run Sqoop on Windows

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10055/#review19517
-----------------------------------------------------------
Thanks Ahmed.  I found some small issues.   Can you please address them?

THanks
bin/configure-sqoop.cmd
<https://reviews.apache.org/r/10055/#comment40266>

    Shouldn't this be HADOOP_COMMON_HOME without % around it - Otherwise it would be expanded to null string, right?

bin/configure-sqoop.cmd
<https://reviews.apache.org/r/10055/#comment40267>

    See previous comment

bin/configure-sqoop.cmd
<https://reviews.apache.org/r/10055/#comment40268>

    Same as above

bin/configure-sqoop.cmd
<https://reviews.apache.org/r/10055/#comment40269>

    Wouldn't HADOOP_CLASSPATH be additive - that is subsequent invocations will be adding to the HADOOP_CLASSPATH with the same values again and again (it is something like always calling . bin/sqoop in Unix systems.   Should there be a setlocal either in this
- Venkat Ranganathan
On April 22, 2013, 3:26 a.m., Ahmed El Baz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10055/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 3:26 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> A patch implementing the Windows version of Sqoop run scripts. The scripts follow the same logic as there .sh counterparts.
> One difference is to create a Jar which references all classpath elements in its Manifest, and provide that jar as the single jar needed for Sqoop. The reason here is that in some cases if the number of classpath elements is large, HADOOP_CLASSPATH gets very long which causes failures in Windows since there is a limit to command lines.
> As a workaround, I added a step to wrap all jars in the classpath in a single jar, and then use that generated jar (this is also done in hadoop for Windows to handle similar issues)
> I did this in a utility script "BuildJar" which can be used for other components as well.
> This change is specific to Windows scripts, Linux scripts are not affected.
>
>
> This addresses bug SQOOP-954.
>     https://issues.apache.org/jira/browse/SQOOP-954
>
>
> Diffs
> -----
>
>   bin/configure-sqoop.cmd PRE-CREATION
>   bin/sqoop.cmd PRE-CREATION
>   conf/sqoop-env-template.cmd PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10055/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ahmed El Baz
>
>