Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-903 Add schema support to generic JDBC connector


+
Abraham Elmahrek 2013-03-07, 23:46
Copy link to this message
-
Re: Review Request: SQOOP-903 Add schema support to generic JDBC connector
Jarek Cecho 2013-03-09, 18:49

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9808/#review17647
-----------------------------------------------------------
Hi Abe,
thank you very much for working on this. The patch looks good to me. I have just couple of comments:

1) Would you mind removing trailing white space characters? I've highlighted all of them for your convenience.

2) Would you mind adding Validation check in GenericJdbcValidator to ensure that the schema is not used with query based import?

3) I'm seeing failure in integration test TableImportTest, but that will be fixed by SQOOP-919, so it's not a show stopper.

Jarcec
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java
<https://reviews.apache.org/r/9808/#comment37426>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
<https://reviews.apache.org/r/9808/#comment37427>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
<https://reviews.apache.org/r/9808/#comment37428>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
<https://reviews.apache.org/r/9808/#comment37429>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java
<https://reviews.apache.org/r/9808/#comment37430>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java
<https://reviews.apache.org/r/9808/#comment37431>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java
<https://reviews.apache.org/r/9808/#comment37432>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java
<https://reviews.apache.org/r/9808/#comment37433>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java
<https://reviews.apache.org/r/9808/#comment37434>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java
<https://reviews.apache.org/r/9808/#comment37435>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java
<https://reviews.apache.org/r/9808/#comment37436>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java
<https://reviews.apache.org/r/9808/#comment37437>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java
<https://reviews.apache.org/r/9808/#comment37438>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java
<https://reviews.apache.org/r/9808/#comment37439>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java
<https://reviews.apache.org/r/9808/#comment37440>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java
<https://reviews.apache.org/r/9808/#comment37441>

    Nit: Trailing whitespace characters

connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java
<https://reviews.apache.org/r/9808/#comment37442>

    Nit: Trailing whitespace characters
- Jarek Cecho
On March 7, 2013, 11:46 p.m., Abraham Elmahrek wrote:
+
Abraham Elmahrek 2013-03-11, 19:33
+
Abraham Elmahrek 2013-03-12, 00:31
+
Jarek Cecho 2013-03-15, 04:50
+
Jarek Cecho 2013-03-15, 04:52