Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Re: Review Request 10964: SQOOP-927 Sqoop2: Integration: Mapreduce specific tests should be running on MiniCluster


+
Abraham Elmahrek 2013-07-04, 00:15
+
Abraham Elmahrek 2013-07-04, 19:59
+
Jarek Cecho 2013-07-08, 15:38
+
Abraham Elmahrek 2013-07-08, 20:20
+
Abraham Elmahrek 2013-07-08, 20:47
+
Jarek Cecho 2013-07-09, 18:14
+
Abraham Elmahrek 2013-07-10, 23:27
+
Jarek Cecho 2013-07-11, 20:58
+
Abraham Elmahrek 2013-07-10, 23:27
+
Jarek Cecho 2013-07-11, 20:49
+
Abraham Elmahrek 2013-07-19, 23:29
+
Jarek Cecho 2013-07-22, 16:10
+
Abraham Elmahrek 2013-07-19, 23:33
+
Jarek Cecho 2013-07-22, 17:00
+
Abraham Elmahrek 2013-08-16, 00:17
+
Jarek Cecho 2013-08-23, 23:24
Copy link to this message
-
Re: Review Request 10964: SQOOP-927 Sqoop2: Integration: Mapreduce specific tests should be running on MiniCluster
Jarek Cecho 2013-08-26, 17:28


> On Aug. 23, 2013, 11:24 p.m., Jarek Cecho wrote:
> > test/src/main/java/org/apache/sqoop/test/hadoop/HadoopMiniClusterRunner.java, lines 71-72
> > <https://reviews.apache.org/r/10964/diff/7/?file=341609#file341609line71>
> >
> >     Nit: Wouldn't make sense to log "Stopping" and then start stopping the service?
>
> Abraham Elmahrek wrote:
>     I think you mean "Stopping..." then "Stopped"?

My apologies I should have express myself better. I actually mean to exchange the order of the lines. Firstly log that we will do something and than do it, rather than do it and then say "we were doing it".
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10964/#review25479
-----------------------------------------------------------
On Aug. 26, 2013, 5:24 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10964/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 5:24 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-927
>     https://issues.apache.org/jira/browse/SQOOP-927
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit ff7dba55a09dd7789a34136233000c625759e583
> Author: Abraham Elmahrek <[EMAIL PROTECTED]>
> Date:   Fri Apr 26 15:10:24 2013 -0700
>
>     SQOOP-927 Sqoop2: Integration: Mapreduce specific tests should be running on MiniCluster
>    
>     Handle MiniDFSCluster and MiniMRClientCluster on own.
>    
>     Set yarn.application.classpath to get over classpath errors.
>     Set to use fair scheduler.
>
> :100644 100644 0abbb18... f09704b... M pom.xml
> :100644 100644 6eb3184... a4c2a5b... M test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java
> :100644 100644 0f48a8b... 758c885... M test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java
>
>
> Diffs
> -----
>
>   pom.xml 513b6d0570ee6f1ec32f8c35a403becc1cfa156a
>   test/pom.xml 8001fcec29bf5a7d9c3119b9f6ef548f678e1ebe
>   test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java c17527285167104994d78f5919b7f11c0c31cd15
>   test/src/main/java/org/apache/sqoop/test/hadoop/HadoopLocalRunner.java PRE-CREATION
>   test/src/main/java/org/apache/sqoop/test/hadoop/HadoopMiniClusterRunner.java PRE-CREATION
>   test/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunner.java PRE-CREATION
>   test/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunnerFactory.java PRE-CREATION
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java d10b94268babeb3dc7b1d2450776af5fd8449fd3
>   test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java efdfed4e2065c0c01c16da88cf55705ab13d7bcf
>   test/src/main/java/org/apache/sqoop/test/utils/HdfsUtils.java 95dd177a11c5d822e35ca54e5d93785f0a40fbfc
>
> Diff: https://reviews.apache.org/r/10964/diff/
>
>
> Testing
> -------
>
> Ran integration tests without and with miniclusters.
> Currently need to use both miniclusters or neither for tests to work.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>

+
Abraham Elmahrek 2013-08-26, 17:23
+
Abraham Elmahrek 2013-08-26, 17:24
+
Abraham Elmahrek 2013-10-18, 02:00
+
Jarek Cecho 2013-10-22, 23:41
+
Jarek Cecho 2013-10-16, 22:27
+
Jarek Cecho 2013-10-17, 21:28
+
Abraham Elmahrek 2013-10-16, 22:51