-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38836/#review100918
-----------------------------------------------------------
Thank you for the patch Abe!
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java (line 38)
<https://reviews.apache.org/r/38836/#comment158180>

    Let's use shorter and dash separated "sensitive-pattern" key here to be in the line with other JSON keys that we're using?

common/src/main/java/org/apache/sqoop/model/MMapInput.java (line 35)
<https://reviews.apache.org/r/38836/#comment158186>

    For normal sensitive values we're using empty string or type's default (like 0 for integers, ...). I'm wondering whether we should do the same for map keys to stay consistent - what do you think?
Jarcec

- Jarek Cecho
On Sept. 29, 2015, 1:17 a.m., Abraham Fine wrote:

NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB