Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Drill, mail # dev - Review Request 14764: Patch for DRILL-230


+
Steven Phillips 2013-10-18, 21:21
+
Timothy Chen 2013-10-21, 06:25
+
Timothy Chen 2013-10-21, 06:14
+
Steven Phillips 2013-10-23, 20:11
+
Ashish Paliwal 2013-10-24, 06:13
Copy link to this message
-
Re: Review Request 14764: Patch for DRILL-230
Steven Phillips 2013-10-25, 18:52


> On Oct. 24, 2013, 6:13 a.m., Ashish Paliwal wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/cache/DrillSerializable.java, line 27
> > <https://reviews.apache.org/r/14764/diff/2/?file=369969#file369969line27>
> >
> >     Is there any specific reason why Serializable or Externalizable won't work in the context?

HazelCache requires classes to Implement DataSerializable. But we want to keep HazelCast specific implementation details abstract, so I created the DrillSerializable interface, that works easily with the DataSerializable interface, but could also be used with other implementations.
> On Oct. 24, 2013, 6:13 a.m., Ashish Paliwal wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/cache/DrillSerializable.java, line 28
> > <https://reviews.apache.org/r/14764/diff/2/?file=369969#file369969line28>
> >
> >     Do we need Logger here, IMHO, better to leave it for implementation classes

We have these loggers scattered in many places. It probably makes sense to remove them from Interfaces, but that is not specific to this interface. This should be fixed throughout the code in another jira.
- Steven
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14764/#review27447
-----------------------------------------------------------
On Oct. 25, 2013, 12:17 p.m., Steven Phillips wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14764/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2013, 12:17 p.m.)
>
>
> Review request for drill.
>
>
> Bugs: DRILL-230
>     https://issues.apache.org/jira/browse/DRILL-230
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-230: address additional code review comments
>
>
> added some comments
>
>
> rename some classes
>
>
> Addressing comments in code review, abstract out references to HazelCache
>
>
> DRILL-230: Build a sampling range partitioner
>
>
> Diffs
> -----
>
>   common/src/main/java/org/apache/drill/common/expression/OutputTypeDeterminer.java ed227ec4a958077922bbcf943f5dcadc1b05686e
>   common/src/main/java/org/apache/drill/common/util/DataInputInputStream.java PRE-CREATION
>   common/src/main/java/org/apache/drill/common/util/DataOutputOutputStream.java PRE-CREATION
>   distribution/src/resources/submit_plan fee182052b8636e3bbf5e9545816057f89bba32a
>   exec/java-exec/pom.xml f6543f9b63bd3385fb0dfefa2b2367c1eab97484
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/Counter.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedCache.java d1b0e89adc373b0d515860f5985d88e5203d8a65
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedMap.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedMultiMap.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/DrillSerializable.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/HCDrillSerializableWrapper.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/HCSerializableWrapperClasses.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/HazelCache.java 22435bd0396726860b6b30657787098f4a4d94c7
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/LocalCache.java 79675c3a6c2c573941d965a62da73d9447ee90e5
>   exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorContainerSerializable.java PRE-CREATION
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 3dadb0cc87c7d234cc545acec505aab46fe689e1
>   exec/java-exec/src/main/java/org/apache/drill/exec/client/QuerySubmitter.java 2d5c10594ff4212515c7a84e6909db5cc1402717
>   exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java bb9fc251f38f95c0e7174c934408cd99456a2286
+
Ashish Paliwal 2013-10-26, 04:11
+
Jacques Nadeau 2013-10-23, 23:50
+
Steven Phillips 2013-10-25, 12:08
+
Steven Phillips 2013-10-25, 12:15
+
Steven Phillips 2013-10-25, 12:17
+
Jacques Nadeau 2013-10-30, 21:07