Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 13866: SQOOP-1185 LobAvroImportTestCase is sensitive to test method order execution


Copy link to this message
-
Review Request 13866: SQOOP-1185 LobAvroImportTestCase is sensitive to test method order execution

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13866/
-----------------------------------------------------------

Review request for Sqoop.
Bugs: SQOOP-1185
    https://issues.apache.org/jira/browse/SQOOP-1185
Repository: sqoop-trunk
Description
-------

I was able to think about two high level options how to solve the issue.

1) Rewrite the tests to be order independent by introducing logic that will get the mapreduce job id instead of depending on getTableNum().
2) Make the tests ordered.

I've decided to go with the less intrusive way (2) and make the test method execution ordered by test method name (e.g. the "working" case) using facilities provided by junit 4.11.
Diffs
-----

  ivy/libraries.properties df1a08fc4ba3b00481157c9bbe7baee4b859b9a6
  src/test/com/cloudera/sqoop/testutil/LobAvroImportTestCase.java 26a4e5b84b5cf2918d05f47d6b6961c2f8bbd173

Diff: https://reviews.apache.org/r/13866/diff/
Testing
-------

I've tested third party test OracleLobAvroImportTest to ensure that this is no longer an issue. I've also run all the unit tests to ensure that there won't be issues with upgraded junit version.
Thanks,

Jarek Cecho