Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request 12342: Fix for SQOOP-1097


+
Venkat Ranganathan 2013-07-08, 22:16
+
Jarek Cecho 2013-07-09, 16:39
+
Venkat Ranganathan 2013-07-09, 19:52
+
Jarek Cecho 2013-07-10, 02:05
Copy link to this message
-
Re: Review Request 12342: Fix for SQOOP-1097
Venkat Ranganathan 2013-07-10, 03:07

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12342/
-----------------------------------------------------------

(Updated July 10, 2013, 3:07 a.m.)
Review request for Sqoop.
Changes
-------

Fixed the trailing space.   Sorry about that.   Uploading it to the JIRA as well.

Thanks

Venkat
Bugs: SQOOP-1097
    https://issues.apache.org/jira/browse/SQOOP-1097
Repository: sqoop-trunk
Description
-------

Fix for mysql export using procedure.   While fixing this, found that Oracle export also has additional issues when using DB specific types that are not handled.   Fixed both the issues and provided a generic implementation for future db tests.
Diffs (updated)
-----

  src/java/org/apache/sqoop/manager/ConnManager.java c9e05da
  src/java/org/apache/sqoop/manager/MySQLManager.java 2090b1a
  src/java/org/apache/sqoop/manager/OracleManager.java edc888e
  src/java/org/apache/sqoop/manager/SqlManager.java e96368b
  src/test/com/cloudera/sqoop/ThirdPartyTests.java 7fae052
  src/test/org/apache/sqoop/TestExportUsingProcedure.java 6414ef7
  src/test/org/apache/sqoop/manager/mysql/MySqlCallExportTest.java PRE-CREATION
  src/test/org/apache/sqoop/manager/oracle/OracleCallExportTest.java PRE-CREATION

Diff: https://reviews.apache.org/r/12342/diff/
Testing
-------

All unit tests pass.  Created a mysql and oracle specific test for testing both the functionality of doing procedure based export and handling db specific types
Thanks,

Venkat Ranganathan

+
Jarek Cecho 2013-07-10, 04:56