Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig >> mail # dev >> Review Request 15852: PIG-3581 Incorrect scope resolution with nested foreach


Copy link to this message
-
Re: Review Request 15852: PIG-3581 Incorrect scope resolution with nested foreach


> On Nov. 26, 2013, 3:32 p.m., Xuefu Zhang wrote:
> > trunk/src/org/apache/pig/parser/LogicalPlanGenerator.g, line 1768
> > <https://reviews.apache.org/r/15852/diff/1/?file=391109#file391109line1768>
> >
> >     If I'm not mistaken, this change seems allowing scalar expression outside nested foreach, which I don't think is supported.

scalars are allowed anywhere in the script (nested or otherwise). I don't understand the concern here.
- Aniket
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15852/#review29435
-----------------------------------------------------------
On Nov. 26, 2013, 2:22 a.m., Aniket Mokashi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15852/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2013, 2:22 a.m.)
>
>
> Review request for pig, Cheolsoo Park, Julien Le Dem, and Xuefu Zhang.
>
>
> Bugs: PIG-3581
>     https://issues.apache.org/jira/browse/PIG-3581
>
>
> Repository: pig
>
>
> Description
> -------
>
> give more precedence to inner aliases when resolving names in nested foreach.
>
>
> Diffs
> -----
>
>   trunk/src/org/apache/pig/parser/LogicalPlanGenerator.g 1544731
>   trunk/test/org/apache/pig/test/TestPigServer.java 1544731
>
> Diff: https://reviews.apache.org/r/15852/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aniket Mokashi
>
>