Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request: FLUME-1769.Replicating channel selector should support optional channels


Copy link to this message
-
Re: Review Request: FLUME-1769.Replicating channel selector should support optional channels


> On Dec. 7, 2012, 8:30 p.m., Brock Noland wrote:
> > flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java, line 73
> > <https://reviews.apache.org/r/8413/diff/5/?file=235844#file235844line73>
> >
> >     The method that was deleted channels being null. That should be handled here as well, correct?
> >    
> >     I am seeing the following tests failures:
> >    
> >     Tests in error:
> >       testNoDefault(org.apache.flume.channel.TestMultiplexingChannelSelector)
> >      testOnlyOptional(org.apache.flume.channel.TestMultiplexingChannelSelector)

Ah sorry. Since the 2 patches affected the same code, looks like some code ended up missing.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8413/#review14181
-----------------------------------------------------------
On Dec. 7, 2012, 8:05 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8413/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2012, 8:05 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Replicating channel selector should support optional channels
>
>
> This addresses bug FLUME-1769.
>     https://issues.apache.org/jira/browse/FLUME-1769
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannelSelector.java 939257d
>   flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java 54e4b20
>   flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java 8f22746
>   flume-ng-core/src/test/java/org/apache/flume/channel/TestReplicatingChannelSelector.java e671364
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 70cb285
>
> Diff: https://reviews.apache.org/r/8413/diff/
>
>
> Testing
> -------
>
> Added unit tests to handle this case
>
>
> Thanks,
>
> Hari Shreedharan
>
>