Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Re: Review Request: FLUME-1864: Allow hdfs idle callback to clean up closed bucket writers


Copy link to this message
-
Re: Review Request: FLUME-1864: Allow hdfs idle callback to clean up closed bucket writers
Juhani Connolly 2013-02-08, 02:10

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9052/#review16318
-----------------------------------------------------------
A review on this would be appreciated. We've reduced the default open files to 100 but this would also help with the underlying problem

- Juhani Connolly
On Jan. 24, 2013, 1:46 a.m., Juhani Connolly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9052/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 1:46 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Stops close() from removing the idle callback and skips close in the idle callback if the writer is already closed.
>
>
> Diffs
> -----
>
>   flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 3f31ef2
>
> Diff: https://reviews.apache.org/r/9052/diff/
>
>
> Testing
> -------
>
> Tests pass. Since sfWriters is protected it is hard to verify the changed behavior in unit tests. I however verified the behaviour in the java debugger.
>
>
> Thanks,
>
> Juhani Connolly
>
>