Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: Fix for SQOOP-1029


+
Venkat Ranganathan 2013-05-04, 23:54
+
Venkat Ranganathan 2013-05-06, 05:04
+
Jarek Cecho 2013-05-20, 13:15
+
Jarek Cecho 2013-05-20, 13:15
+
Jarek Cecho 2013-05-06, 04:32
+
Venkat Ranganathan 2013-05-06, 05:04
+
Shruti Joshi 2013-05-10, 12:06
+
Jarek Cecho 2013-05-21, 08:56
+
Shruti Joshi 2013-05-23, 07:55
+
Shruti Joshi 2013-05-23, 07:52
+
Shruti Joshi 2013-05-22, 13:22
+
Shruti Joshi 2013-05-27, 11:22
+
Jarek Cecho 2013-05-28, 10:24
+
Jarek Cecho 2013-05-29, 06:54
+
Shruti Joshi 2013-05-28, 12:16
+
Shruti Joshi 2013-05-30, 13:12
+
Shruti Joshi 2013-06-03, 13:06
+
Shruti Joshi 2013-06-03, 13:04
+
Jarek Cecho 2013-06-08, 16:19
+
Shruti Joshi 2013-06-19, 10:12
+
Shruti Joshi 2013-06-19, 10:17
+
Shruti Joshi 2013-06-20, 08:50
+
Jarek Cecho 2013-06-20, 16:20
+
Shruti Joshi 2013-06-21, 04:12
+
Jarek Cecho 2013-06-19, 20:50
+
Shruti Joshi 2013-06-21, 03:40
+
Venkat Ranganathan 2013-05-21, 01:00
+
Venkat Ranganathan 2013-05-21, 04:09
+
Jarek Cecho 2013-05-21, 08:39
+
Venkat Ranganathan 2013-05-21, 16:42
+
Venkat Ranganathan 2013-05-21, 18:57
+
Jarek Cecho 2013-05-22, 06:31
+
Venkat Ranganathan 2013-05-30, 06:07
+
Venkat Ranganathan 2013-05-30, 18:25
+
Abraham Elmahrek 2013-05-31, 20:30
+
Venkat Ranganathan 2013-06-01, 00:07
+
Abraham Elmahrek 2013-05-31, 20:33
+
Jarek Cecho 2013-06-10, 15:36
+
Venkat Ranganathan 2013-06-10, 16:06
+
Venkat Ranganathan 2013-06-11, 18:41
+
Venkat Ranganathan 2013-06-12, 17:23
+
Venkat Ranganathan 2013-06-13, 05:46
+
Abraham Elmahrek 2013-06-13, 19:00
Copy link to this message
-
Re: Review Request: Fix for SQOOP-1013

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11537/#review21877
-----------------------------------------------------------

connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
<https://reviews.apache.org/r/11537/#comment45173>

    Thanks Abraham.   Good point.  Even though the comments mention the choice of the value, it can be more prominent.   When we revisit this as part of the follow on JIRA, we can do that
- Venkat Ranganathan
On June 13, 2013, 5:46 a.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11537/
> -----------------------------------------------------------
>
> (Updated June 13, 2013, 5:46 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> This addresses Boolean, date, time, and timestamp splitters.
>
> THis also disallows char type splitters as discussed in SQOOP-976
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java f80f30d
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java ee314d0
>
> Diff: https://reviews.apache.org/r/11537/diff/
>
>
> Testing
> -------
>
> Introduced new unit tests to test new functionality
> All tests pass
>
>
> Thanks,
>
> Venkat Ranganathan
>
>

+
Jarek Cecho 2013-06-13, 20:35
+
Abraham Elmahrek 2013-06-13, 01:41
+
Venkat Ranganathan 2013-06-13, 05:44
+
Venkat Ranganathan 2013-06-19, 21:48
+
Jarek Cecho 2013-06-20, 22:02