Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: SQOOP-882 Sqoop2 integration: Auxiliary classes for various database support


Copy link to this message
-
Re: Review Request: SQOOP-882 Sqoop2 integration: Auxiliary classes for various database support

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9487/#review17000
-----------------------------------------------------------

Ship it!
Ship It!

- Cheolsoo Park
On Feb. 23, 2013, 5:16 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9487/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2013, 5:16 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've created abstract database handler that can be used in tests to interact with remote databases (create tables, insert data, ...). I've also provided concrete implementation based on Derby. I'll add more handlers later if this patch gets accepted.
>
>
> This addresses bug SQOOP-882.
>     https://issues.apache.org/jira/browse/SQOOP-882
>
>
> Diffs
> -----
>
>   pom.xml 5e1b43b63d2e6baccfdf3927d3449d0b5ea189fb
>   test/pom.xml 66382b6fd7d17d4b345f5960082fb39e2ee100d4
>   test/src/main/java/org/apache/sqoop/test/db/DatabaseProvider.java PRE-CREATION
>   test/src/main/java/org/apache/sqoop/test/db/DerbyProvider.java PRE-CREATION
>   test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java 5fa294a2adc4a2f6855fda6e8853009b53554710
>   test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java eacf3045580cf93879905b706f1114a407283bad
>   test/src/test/java/org/apache/sqoop/integration/connector/ConnectorTestCase.java PRE-CREATION
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java PRE-CREATION
>   test/src/test/resources/log4j.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9487/diff/
>
>
> Testing
> -------
>
> I've provided first "real" integration test that this utilizing newly created database handler to set up the environment and move some data. Sadly we currently do not have convenient client API that we can use, so the implementation for connection and job creation is quite "hacky". I'll improve that once we will have reasonable client API.
>
>
> Thanks,
>
> Jarek Cecho
>
>