Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1898. Thrift Source


+
Hari Shreedharan 2013-02-07, 03:38
+
Brock Noland 2013-02-07, 15:23
+
Hari Shreedharan 2013-02-07, 22:04
+
Hari Shreedharan 2013-02-07, 22:03
+
Hari Shreedharan 2013-02-07, 22:47
+
Hari Shreedharan 2013-02-08, 09:36
+
Brock Noland 2013-02-10, 21:04
+
Hari Shreedharan 2013-02-10, 22:48
+
Hari Shreedharan 2013-02-10, 22:50
Copy link to this message
-
Re: Review Request: FLUME-1898. Thrift Source

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9352/#review16422
-----------------------------------------------------------
Hi,

Patch looks good, I tried running tests and got the following which does not occur on naked trunk:

[INFO] Scanning for projects...
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]  
[ERROR]   The project org.apache.flume:flume-ng-core:1.4.0-SNAPSHOT (/Users/noland/workspaces/flume-apache-trunk-golden/flume/flume-ng-core/pom.xml) has 1 error
[ERROR]     'dependencies.dependency.version' for org.apache.flume:flume-ng-sdk:jar:tests is missing. @ line 140, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException

- Brock Noland
On Feb. 10, 2013, 10:50 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9352/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2013, 10:50 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Thrift Source.
>
>
> This addresses bug FLUME-1898.
>     https://issues.apache.org/jira/browse/FLUME-1898
>
>
> Diffs
> -----
>
>   flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java 3312b04
>   flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java 058ca1c
>   flume-ng-core/pom.xml 7db4f23
>   flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9352/diff/
>
>
> Testing
> -------
>
> Added several unit tests.
>
>
> Thanks,
>
> Hari Shreedharan
>
>

+
Hari Shreedharan 2013-02-11, 17:44
+
Brock Noland 2013-02-11, 18:54