Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request: FLUME-1906. Optionally disable WAL in HBase Sink


Copy link to this message
-
Re: Review Request: FLUME-1906. Optionally disable WAL in HBase Sink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9457/#review16613
-----------------------------------------------------------
Looks good to me. Thanks.
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java
<https://reviews.apache.org/r/9457/#comment35247>

    when config changes from enableWal = false to enableWal = true, don't we need to log it? I think it helps on debugging.

flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java
<https://reviews.apache.org/r/9457/#comment35250>

    i think "memstore of the region in a region server"
- Mubarak Seyed
On Feb. 14, 2013, 9:33 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9457/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2013, 9:33 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added support for WAL disabling optionally.
>
>
> This addresses bug FLUME-1906.
>     https://issues.apache.org/jira/browse/FLUME-1906
>
>
> Diffs
> -----
>
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 0b6f885
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java 835a69e
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java fb6bd4e
>
> Diff: https://reviews.apache.org/r/9457/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Shreedharan
>
>