Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Zookeeper, mail # dev - Review Request 15317: Send FLE notifications only to voters in current config, reverting a change made in zk-107


Copy link to this message
-
Re: Review Request 15317: Send FLE notifications only to voters in current config, reverting a change made in zk-107
Raul Gutierrez Segales 2013-11-07, 19:21

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15317/#review28421
-----------------------------------------------------------

./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
<https://reviews.apache.org/r/15317/#comment55237>

    nit: For an example

./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
<https://reviews.apache.org/r/15317/#comment55239>

    two nits:
    - maybe these comments can be merged with the comment block before the method definition (it's a short method anyway).
    - Either use or don't use . at the end of your sentences (consistently).

./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
<https://reviews.apache.org/r/15317/#comment55235>

    super nit: if possible, lets not introduce the trailing spaces.

./src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java
<https://reviews.apache.org/r/15317/#comment55240>

    ditto

./src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java
<https://reviews.apache.org/r/15317/#comment55241>

    ditto wrt trailing spaces (same for the other recurrences).
- Raul Gutierrez Segales
On Nov. 7, 2013, 6:50 p.m., Alexander Shraer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15317/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2013, 6:50 p.m.)
>
>
> Review request for zookeeper.
>
>
> Bugs: ZOOKEEPER-1807
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1807
>
>
> Repository: zookeeper
>
>
> Description
> -------
>
> ZOOKEEPER-1807
>
>
> Diffs
> -----
>
>   ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1539709
>   ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1539709
>   ./src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java 1539709
>
> Diff: https://reviews.apache.org/r/15317/diff/
>
>
> Testing
> -------
>
> two tests added to ReconfigRecoveryTest
>
>
> Thanks,
>
> Alexander Shraer
>
>