Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 15449: session/operation timeout for hiveserver2


Copy link to this message
-
Re: Review Request 15449: session/operation timeout for hiveserver2
Carl Steinbach 2013-11-15, 09:21

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15449/#review28950
-----------------------------------------------------------

service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
<https://reviews.apache.org/r/15449/#comment56006>

    Can we change the name to something like closeExpiredOperations()?

service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
<https://reviews.apache.org/r/15449/#comment56007>

    Is this actually necessary or is it a hypothetical bug you're guarding against? Is it possible to get rid of opHandleSet and push most of this logic down into OperationManager?

service/src/java/org/apache/hive/service/cli/session/SessionManager.java
<https://reviews.apache.org/r/15449/#comment56008>

    Change the name to timeoutChecker or sessionTimeoutChecker?
- Carl Steinbach
On Nov. 13, 2013, 1:21 a.m., Navis Ryu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15449/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2013, 1:21 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-5799
>     https://issues.apache.org/jira/browse/HIVE-5799
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Need some timeout facility for preventing resource leakages from instable or bad clients.
>
>
> Diffs
> -----
>
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 32ab3d8
>   conf/hive-default.xml.template c574ab5
>   service/src/java/org/apache/hive/service/cli/OperationState.java 1ec6bd1
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 6f4b8dc
>   service/src/java/org/apache/hive/service/cli/session/HiveSession.java 00058cc
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java cfda752
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 25c6f38
>
> Diff: https://reviews.apache.org/r/15449/diff/
>
>
> Testing
> -------
>
> Confirmed in the local environment.
>
>
> Thanks,
>
> Navis Ryu
>
>