Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig, mail # dev - Review Request: Add BigInteger and BigDecimal to Pig


Copy link to this message
-
Re: Review Request: Add BigInteger and BigDecimal to Pig
Cheolsoo Park 2013-01-20, 23:34

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9012/#review15532
-----------------------------------------------------------

src/org/apache/pig/backend/hadoop/BigDecimalWritable.java
<https://reviews.apache.org/r/9012/#comment33533>

    I believe this is a typo: 'b1' => 'b2'.

src/org/apache/pig/backend/hadoop/BigDecimalWritable.java
<https://reviews.apache.org/r/9012/#comment33536>

    bye => byte

src/org/apache/pig/backend/hadoop/BigIntegerWritable.java
<https://reviews.apache.org/r/9012/#comment33534>

    I believe this is a typo: 'b1' => 'b2'.

src/org/apache/pig/backend/hadoop/BigIntegerWritable.java
<https://reviews.apache.org/r/9012/#comment33537>

    bye => byte

src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POCast.java
<https://reviews.apache.org/r/9012/#comment33538>

    Shouldn't it be bytesToBigDecimal?

src/org/apache/pig/data/DataType.java
<https://reviews.apache.org/r/9012/#comment33539>

    Typo: BigInteger => BigDecimal.
- Cheolsoo Park
On Jan. 18, 2013, 10:11 p.m., Jonathan Coveney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9012/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 10:11 p.m.)
>
>
> Review request for pig, Alan Gates and Mathias Herberts.
>
>
> Description
> -------
>
> This patch adds big integer and big decimal support to Pig. It could use more tests, something I'd appreciate feedback on (but I wanted to make sure the core implementation is good)
>
>
> This addresses bug PIG-2764.
>     https://issues.apache.org/jira/browse/PIG-2764
>
>
> Diffs
> -----
>
>   .gitignore cc62d7d
>   src/org/apache/pig/LoadCaster.java 574769b
>   src/org/apache/pig/PigWarning.java 5de075f
>   src/org/apache/pig/StoreCaster.java 5fe48de
>   src/org/apache/pig/backend/hadoop/BigDecimalWritable.java PRE-CREATION
>   src/org/apache/pig/backend/hadoop/BigIntegerWritable.java PRE-CREATION
>   src/org/apache/pig/backend/hadoop/HDataType.java 84a56b8
>   src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java 96fba6b
>   src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigBigDecimalRawComparator.java PRE-CREATION
>   src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigBigIntegerRawComparator.java PRE-CREATION
>   src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/partitioners/WeightedRangePartitioner.java 9749339
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/PhysicalOperator.java f40eb43
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Add.java c84b767
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/ConstantExpression.java db3840f
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Divide.java 4656c28
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/EqualToExpr.java 6683beb
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/ExpressionOperator.java 2806336
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/GTOrEqualToExpr.java d64a080
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/GreaterThanExpr.java 704d0b8
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/LTOrEqualToExpr.java 9dc929e
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/LessThanExpr.java 0320698
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Mod.java 6819185
>   src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/Multiply.java 7b57bed