Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Drill, mail # dev - Fwd: Kafka patch review process


Copy link to this message
-
Fwd: Kafka patch review process
Timothy Chen 2013-09-12, 03:19
I think we can do something similar like this so we have one step to push to both jira and rb.

Tim

Sent from my iPhone

Begin forwarded message:

> From: Neha Narkhede <[EMAIL PROTECTED]>
> Date: September 11, 2013, 5:55:28 PM PDT
> To: "[EMAIL PROTECTED]" <[EMAIL PROTECTED]>
> Subject: Kafka patch review process
> Reply-To: [EMAIL PROTECTED]
>
> Hi,
>
> I'm proposing a new patch review process that will save time on code
> reviews and make the patch review process easier, with a one time setup
> cost.
>
> I wrote a tool that will do 2 things -
>
> 1. Create a patch and upload it to an existing JIRA
> 2. Create/update reviewboard with the same patch and link it back to the
> JIRA
> 3. Update JIRA with a comment that points to the reviewboard
>
> To use this tool, you will need to go through a one-time setup cost of
> installing jira command line tools and reviewboard tools. The setup as well
> as usage is documented here
> <https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool>
>
> I've created a rb <https://reviews.apache.org/r/14091/> as well as created
> a JIRA <https://issues.apache.org/jira/browse/KAFKA-1053> for this (yes,
> using the tool :))
>
> So the proposed patch review process is -
>
> 1. Create a JIRA
> 2. Make code changes and commit to local branch
> 3. Use the patch review
> tool<https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool>that
> will update the JIRA with the patch and create/update the
> corresponding reviewboard
>
> Will be great if people can give this a spin and provide feedback on the
> new patch review process.
>
> Thanks,
> Neha