Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request: FLUME-1657 - Regex Extractor Interceptor


+
Cameron Gandevia 2012-10-22, 18:26
Copy link to this message
-
Re: Review Request: FLUME-1657 - Regex Extractor Interceptor
Brock Noland 2012-11-06, 17:03

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7700/#review13155
-----------------------------------------------------------

flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexExtractorInterceptor.java
<https://reviews.apache.org/r/7700/#comment28310>

    I think we should be passing an explicit Charset here like UTF8?

flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexExtractorInterceptor.java
<https://reviews.apache.org/r/7700/#comment28311>

    If serializerString had ,, then splitNameAndSerializer[0].trim(); would throw an index out of bounds correct?
- Brock Noland
On Oct. 22, 2012, 6:26 p.m., Cameron Gandevia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7700/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2012, 6:26 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> A RegexExtractor interceptor that will allow users to extract regex matches and append them as header fields of the event.
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/interceptor/InterceptorType.java c478337
>   flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexExtractorInterceptor.java PRE-CREATION
>   flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexExtractorInterceptorMillisSerializer.java PRE-CREATION
>   flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexExtractorInterceptorPassThroughSerializer.java PRE-CREATION
>   flume-ng-core/src/main/java/org/apache/flume/interceptor/RegexExtractorInterceptorSerializer.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexExtractorInterceptor.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexExtractorInterceptorMillisSerializer.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexExtractorInterceptorPassThroughSerializer.java PRE-CREATION
>   flume-ng-doc/sphinx/FlumeUserGuide.rst bd244d4
>
> Diff: https://reviews.apache.org/r/7700/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Cameron Gandevia
>
>

+
Brock Noland 2012-11-06, 17:05
+
Cameron Gandevia 2012-11-14, 01:24
+
Brock Noland 2012-11-14, 01:57
+
Hari Shreedharan 2012-11-14, 02:15
+
Brock Noland 2012-11-14, 20:55
+
Cameron Gandevia 2012-11-14, 01:24
+
Brock Noland 2012-11-14, 01:57
+
Cameron Gandevia 2012-11-14, 22:03
+
Brock Noland 2012-11-15, 13:01
+
Brock Noland 2012-11-15, 15:35
+
Roshan Naik 2012-11-15, 19:31
+
Brock Noland 2012-11-15, 19:36
+
Hari Shreedharan 2012-11-15, 19:40
+
Roshan Naik 2012-11-15, 19:46