Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request 15107: Moving BlobHandler out of morphline sink and into HTTP source


Copy link to this message
-
Re: Review Request 15107: Moving BlobHandler out of morphline sink and into HTTP source


> On Nov. 5, 2013, 1:47 a.m., Wolfgang Hoschek wrote:
> > flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobHandler.java, line 43
> > <https://reviews.apache.org/r/15107/diff/1-2/?file=374518#file374518line43>
> >
> >     realBlobHandler seems obsolete now

oops ... yes.
- Roshan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15107/#review28165
-----------------------------------------------------------
On Nov. 5, 2013, 1:42 a.m., Roshan Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15107/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 1:42 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2226
>     https://issues.apache.org/jira/browse/FLUME-2226
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> - Moved BlobHandler out of morphline sink and into HTTP source along with tests.
> - Updated docs to reflect new FQCN
> - Retained dummy class for old FQCN compat
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/http/BlobHandler.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletByteRequestWrapper.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/source/http/TestBlobHandler.java PRE-CREATION
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 3a3038c
>   flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobHandler.java e84dec1
>   flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/FlumeHttpServletRequestWrapper.java 9711a3a
>   flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/TestBlobHandler.java 3e7de99
>
> Diff: https://reviews.apache.org/r/15107/diff/
>
>
> Testing
> -------
>
> Ran unit tests & some manual Test.
>
>
> Thanks,
>
> Roshan Naik
>
>