Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-851 Sqoop2: NullPointerException in Mapreduce Submission engine initialization


+
Jarek Cecho 2013-01-23, 22:32
+
Cheolsoo Park 2013-01-30, 23:43
Copy link to this message
-
Re: Review Request: SQOOP-851 Sqoop2: NullPointerException in Mapreduce Submission engine initialization
Jarek Cecho 2013-01-31, 16:59


> On Jan. 30, 2013, 11:43 p.m., Cheolsoo Park wrote:
> > submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java, line 96
> > <https://reviews.apache.org/r/9076/diff/1/?file=251406#file251406line96>
> >
> >     Looking at the Java Doc of File, list returns null when the File is not a directory. Can you be even more specific in the error message? Because your message can also be interpreted as "(Hadoop conf dir is valid,) but no conf files were found", which is not entirely true.
> >    
> >     How about saying something like "'configDirectory' is not a directory"?

Thank you for catching this Cheolsoo. I did not realized that the error message might be understood differently.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9076/#review15902
-----------------------------------------------------------
On Jan. 23, 2013, 10:32 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9076/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 10:32 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Problem is that method File.list() in java might return null in addition to empty array. I've add simple check that will throw more informative exception in case that configuration path is not valid.
>
>
> This addresses bug SQOOP-851.
>     https://issues.apache.org/jira/browse/SQOOP-851
>
>
> Diffs
> -----
>
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 1a144d0
>
> Diff: https://reviews.apache.org/r/9076/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've tested simple import on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

+
Jarek Cecho 2013-01-31, 17:00
+
Cheolsoo Park 2013-01-31, 17:16